Hello,
I found that new revision of kdelibs contains these new headers. Are really needed there? In any case, i cannot found where FT_FREETYPE_H is set.
--- /home/serghei/projects/trinity.old/kdelibs/kdeui/kaction.cpp 2010-08-28 16:38:47.000000000 +0300 +++ /home/serghei/projects/trinity/kdelibs/kdeui/kaction.cpp 2010-09-12 17:23:12.000000000 +0300 @@ -42,6 +42,17 @@ #include <ktoolbar.h> #include <ktoolbarbutton.h>
+#include <ft2build.h> +#include FT_FREETYPE_H +#include <X11/Xdefs.h> +#include <X11/Xlib.h> +#include <X11/Xatom.h> +#include <X11/Intrinsic.h> +#include <X11/StringDefs.h> +#include <X11/Shell.h> + +#include <X11/Xft/Xft.h> + /** * How it works. * KActionCollection is an organizing container for KActions.
Hello,
I found that new revision of kdelibs contains these new headers. Are really needed there? In any case, i cannot found where FT_FREETYPE_H is set.
--- /home/serghei/projects/trinity.old/kdelibs/kdeui/kaction.cpp 2010-08-28 16:38:47.000000000 +0300 +++ /home/serghei/projects/trinity/kdelibs/kdeui/kaction.cpp 2010-09-12 17:23:12.000000000 +0300 @@ -42,6 +42,17 @@ #include <ktoolbar.h> #include <ktoolbarbutton.h>
+#include <ft2build.h> +#include FT_FREETYPE_H +#include <X11/Xdefs.h> +#include <X11/Xlib.h> +#include <X11/Xatom.h> +#include <X11/Intrinsic.h> +#include <X11/StringDefs.h> +#include <X11/Shell.h>
+#include <X11/Xft/Xft.h>
/**
- How it works.
- KActionCollection is an organizing container for KActions.
-- Serghei
I don't know why "#include FREETYPE" is present, but the X11 includes are required. I would personally leave FT_FREETYPE_H in place unless it is causing a build failure under CMake, in which case it can be removed as we are not yet in the feature freeze.
Tim
On Monday 13 September 2010 00:39:09 Timothy Pearson wrote:
Hello,
I found that new revision of kdelibs contains these new headers. Are really needed there? In any case, i cannot found where FT_FREETYPE_H is set.
[...]
I don't know why "#include FREETYPE" is present, but the X11 includes are required. I would personally leave FT_FREETYPE_H in place unless it is causing a build failure under CMake, in which case it can be removed as we are not yet in the feature freeze.
Tim
Yes, build failing because FT_FREETYPE_H is not defined. Also, compiling fine even without X11/freetype inclusions. I can't see in source any X11/freetype calls.
Actually 3 files have this strange inclusion: kactionclasses.cpp, kaction.cpp, and kfontcombo.cpp.
On Monday 13 September 2010 00:39:09 Timothy Pearson wrote:
Hello,
I found that new revision of kdelibs contains these new headers. Are really needed there? In any case, i cannot found where FT_FREETYPE_H is set.
[...]
I don't know why "#include FREETYPE" is present, but the X11 includes are required. I would personally leave FT_FREETYPE_H in place unless it is causing a build failure under CMake, in which case it can be removed as we are not yet in the feature freeze.
Tim
Yes, build failing because FT_FREETYPE_H is not defined. Also, compiling fine even without X11/freetype inclusions. I can't see in source any X11/freetype calls.
Actually 3 files have this strange inclusion: kactionclasses.cpp, kaction.cpp, and kfontcombo.cpp.
-- Serghei
Well, you can exercise your new SVN account and remove the FT_FREETYPE_H from those files if you would like. ;-) Just let me know when you have done so, and verified that it does fix your build issue, so that I can initiate a full rebuild test of Trinity.
Tim
On Monday 13 September 2010 01:02:42 Timothy Pearson wrote: [...]
Well, you can exercise your new SVN account and remove the FT_FREETYPE_H from those files if you would like. ;-) Just let me know when you have done so, and verified that it does fix your build issue, so that I can initiate a full rebuild test of Trinity.
cmake building are fine now, i commited changes to svn
-
Serghei Amelian -
Timothy Pearson