Tim, I see that you have updated lots of .desktop files in TDE to honor the XDG compliance. This is a good work, but I've noticed that rpmlint still complains about "missing semicolon as trailing caracter". It looks like the separator is not enough, it needs a trailing caracter too.
François
Le 12/10/2014 10:33, François Andriot a écrit :
Tim, I see that you have updated lots of .desktop files in TDE to honor the XDG compliance. This is a good work, but I've noticed that rpmlint still complains about "missing semicolon as trailing caracter". It looks like the separator is not enough, it needs a trailing caracter too.
François
Forgot to add: the rpmlint complains about "keywords" lines in .desktop files, not the other ones.
In tdegraphics, the "camera" icons are not installed correctly. Attached patch fixes it.
François
On Sunday 12 of October 2014 18:04:41 Slávek Banko wrote:
On Sunday 12 of October 2014 13:19:12 François Andriot wrote:
In tdegraphics, the "camera" icons are not installed correctly. Attached patch fixes it.
François
They should be renamed files *-camera.png?
Ignore this question - I did not have my git tree updated. "git pull --rebase" fix it...
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA224
Tim, I see that you have updated lots of .desktop files in TDE to honor the XDG compliance. This is a good work, but I've noticed that rpmlint still complains about "missing semicolon as trailing caracter". It looks like the separator is not enough, it needs a trailing caracter too.
François
Thanks for bringing this to my attention; while I can't fix it right now I will try to do so in the RC2 merge window. Should be simple enough to do, but will require a lot of rebuilt packages so it is not appropriate for RC1.
Tim
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA224
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA224
Tim, I see that you have updated lots of .desktop files in TDE to honor the XDG compliance. This is a good work, but I've noticed that rpmlint still complains about "missing semicolon as trailing caracter". It looks like the separator is not enough, it needs a trailing caracter too.
François
Thanks for bringing this to my attention; while I can't fix it right now I will try to do so in the RC2 merge window. Should be simple enough to do, but will require a lot of rebuilt packages so it is not appropriate for RC1.
Tim
Looks like the builds are going in such a way that I could fix this for RC1 after all. The changes are now in GIT; let me know if this resolves your lint errors.
Thanks!
Tim
Le 19/10/2014 01:41, Timothy Pearson a écrit :
Looks like the builds are going in such a way that I could fix this for RC1 after all. The changes are now in GIT; let me know if this resolves your lint errors.
Thanks!
Tim
Thanks, but today I still have missing trailing semicolon problem in 'tderesources.desktop' from tdelibs.
Also, in the following files from tdebase:
/opt/trinity/share/applications/tde/arts.desktop /opt/trinity/share/applications/tde/background.desktop /opt/trinity/share/applications/tde/bell.desktop /opt/trinity/share/applications/tde/cache.desktop /opt/trinity/share/applications/tde/cdinfo.desktop /opt/trinity/share/applications/tde/clock.desktop /opt/trinity/share/applications/tde/colors.desktop /opt/trinity/share/applications/tde/componentchooser.desktop /opt/trinity/share/applications/tde/cookies.desktop /opt/trinity/share/applications/tde/crypto.desktop /opt/trinity/share/applications/tde/desktop.desktop /opt/trinity/share/applications/tde/desktopbehavior.desktop /opt/trinity/share/applications/tde/desktoppath.desktop /opt/trinity/share/applications/tde/devices.desktop /opt/trinity/share/applications/tde/ebrowsing.desktop /opt/trinity/share/applications/tde/filebrowser.desktop /opt/trinity/share/applications/tde/fonts.desktop /opt/trinity/share/applications/tde/icons.desktop /opt/trinity/share/applications/tde/interrupts.desktop /opt/trinity/share/applications/tde/ioports.desktop /opt/trinity/share/applications/tde/joystick.desktop /opt/trinity/share/applications/tde/kcmcss.desktop /opt/trinity/share/applications/tde/kcmfontinst.desktop /opt/trinity/share/applications/tde/kcmkded.desktop /opt/trinity/share/applications/tde/kcmlaunch.desktop /opt/trinity/share/applications/tde/kcmnotify.desktop /opt/trinity/share/applications/tde/kcmperformance.desktop /opt/trinity/share/applications/tde/kcmsmserver.desktop /opt/trinity/share/applications/tde/kcmtaskbar.desktop /opt/trinity/share/applications/tde/kcmusb.desktop /opt/trinity/share/applications/tde/kcmview1394.desktop /opt/trinity/share/applications/tde/keys.desktop /opt/trinity/share/applications/tde/kthememanager.desktop /opt/trinity/share/applications/tde/lanbrowser.desktop /opt/trinity/share/applications/tde/language.desktop /opt/trinity/share/applications/tde/media.desktop /opt/trinity/share/applications/tde/memory.desktop /opt/trinity/share/applications/tde/mouse.desktop /opt/trinity/share/applications/tde/netpref.desktop /opt/trinity/share/applications/tde/opengl.desktop /opt/trinity/share/applications/tde/panel.desktop /opt/trinity/share/applications/tde/partitions.desktop /opt/trinity/share/applications/tde/pci.desktop /opt/trinity/share/applications/tde/privacy.desktop /opt/trinity/share/applications/tde/processor.desktop /opt/trinity/share/applications/tde/proxy.desktop /opt/trinity/share/applications/tde/screensaver.desktop /opt/trinity/share/applications/tde/smbstatus.desktop /opt/trinity/share/applications/tde/sound.desktop /opt/trinity/share/applications/tde/spellchecking.desktop /opt/trinity/share/applications/tde/style.desktop /opt/trinity/share/applications/tde/tdehtml_behavior.desktop /opt/trinity/share/applications/tde/tdehtml_fonts.desktop /opt/trinity/share/applications/tde/tdehtml_java_js.desktop /opt/trinity/share/applications/tde/tdm.desktop /opt/trinity/share/applications/tde/useragent.desktop /opt/trinity/share/applications/tde/xserver.desktop
And I bet there are many other in other packages.
We should probably use a more global find and replace method in the while source tree ...
François
Le 19/10/2014 14:18, François Andriot a écrit :
Le 19/10/2014 01:41, Timothy Pearson a écrit :
Looks like the builds are going in such a way that I could fix this for RC1 after all. The changes are now in GIT; let me know if this resolves your lint errors.
Thanks!
Tim
Thanks, but today I still have missing trailing semicolon problem in 'tderesources.desktop' from tdelibs.
Also, in the following files from tdebase:
[...] OK now I understand. The problem I still see is about the translated "Keywords" lines. I see the generic "Keywords" line has been fixed, but not the tranlations. E.g. "Keywords[ar]" still lacks the trailing semicolon.
François
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA224
Le 19/10/2014 14:18, François Andriot a écrit :
Le 19/10/2014 01:41, Timothy Pearson a écrit :
Looks like the builds are going in such a way that I could fix this for RC1 after all. The changes are now in GIT; let me know if this resolves your lint errors.
Thanks!
Tim
Thanks, but today I still have missing trailing semicolon problem in 'tderesources.desktop' from tdelibs.
Also, in the following files from tdebase:
[...] OK now I understand. The problem I still see is about the translated "Keywords" lines. I see the generic "Keywords" line has been fixed, but not the tranlations. E.g. "Keywords[ar]" still lacks the trailing semicolon.
François
My fault; forgot about the translations in my regexp. Fixed in GIT.
Tim
On Monday 20 of October 2014 00:55:44 Timothy Pearson wrote:
Le 19/10/2014 14:18, François Andriot a écrit :
Le 19/10/2014 01:41, Timothy Pearson a écrit :
Looks like the builds are going in such a way that I could fix this for RC1 after all. The changes are now in GIT; let me know if this resolves your lint errors.
Thanks!
Tim
Thanks, but today I still have missing trailing semicolon problem in 'tderesources.desktop' from tdelibs.
Also, in the following files from tdebase:
[...] OK now I understand. The problem I still see is about the translated "Keywords" lines. I see the generic "Keywords" line has been fixed, but not the tranlations. E.g. "Keywords[ar]" still lacks the trailing semicolon.
François
My fault; forgot about the translations in my regexp. Fixed in GIT.
Tim
Tim,
these last commits caused a big problem! Are removed parentheses for language. For example, instead Keywords[bg] is now Keywordsbg.
Everything needed to fix again...
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA224
On Monday 20 of October 2014 00:55:44 Timothy Pearson wrote:
Le 19/10/2014 14:18, François Andriot a écrit :
Le 19/10/2014 01:41, Timothy Pearson a écrit :
Looks like the builds are going in such a way that I could fix this
for
RC1 after all. The changes are now in GIT; let me know if this resolves your lint errors.
Thanks!
Tim
Thanks, but today I still have missing trailing semicolon problem in 'tderesources.desktop' from tdelibs.
Also, in the following files from tdebase:
[...] OK now I understand. The problem I still see is about the translated "Keywords" lines. I see the generic "Keywords" line has been fixed, but not the tranlations. E.g. "Keywords[ar]" still lacks the trailing semicolon.
François
My fault; forgot about the translations in my regexp. Fixed in GIT.
Tim
Tim,
these last commits caused a big problem! Are removed parentheses for language. For example, instead Keywords[bg] is now Keywordsbg.
Everything needed to fix again...
-- Slávek
My mistake; fixed again. Don't have much time for TDE right now; tried to cram the fix in and messed it up instead. :-)
Tim
-
François Andriot -
Slávek Banko -
Timothy Pearson