15 Mar
2016
15 Mar
'16
2:10 p.m.
Hi Fat-Zer, all,
I saw that in CMake processing of UIC files is a called command with redirect
of output. I think that's not the ideal way. Therefore, I propose to modify
it so that it will be used CMake method of processing outputs.
See proposed patch.
Cheers
--
Slávek
15 Mar
15 Mar
2:53 p.m.
New subject: [trinity-devel] CMake × tquic
On 03/15/2016 03:10 PM, Slávek Banko wrote:
Hi Fat-Zer, all,
I saw that in CMake processing of UIC files is a called command with redirect
of output. I think that's not the ideal way. Therefore, I propose to modify
it so that it will be used CMake method of processing outputs.
See proposed patch.
Cheers
Looks good to me. If Alexander is also happy, go ahead and push.
Cheers
Michele
7:37 p.m.
New subject: [trinity-devel] CMake × tquic
2016-03-15 17:10 GMT+03:00 Slávek Banko <slavek.banko(a)axis.cz>cz>:
Hi Fat-Zer, all,
I saw that in CMake processing of UIC files is a called command with redirect
of output. I think that's not the ideal way. Therefore, I propose to modify
it so that it will be used CMake method of processing outputs.
See proposed patch.
Cheers
--
Slávek
Looks fine, but could you please verify that at least tdelibs and
tdebase are build correctly before pushing...
7:41 p.m.
New subject: [trinity-devel] CMake × tquic
Dne út 15. března 2016 Fat-Zer napsal(a):
2016-03-15 17:10 GMT+03:00 Slávek Banko
<slavek.banko(a)axis.cz>cz>:
I tested on tdegames on which I was working. But no problem, I can test even
tdelibs and tdebase.
Thank you.
--
Slávek
Hi Fat-Zer, all,
I saw that in CMake processing of UIC files is a called command with
redirect of output. I think that's not the ideal way. Therefore, I
propose to modify it so that it will be used CMake method of processing
outputs.
See proposed patch.
Cheers
--
Slávek
Looks fine, but could you please verify that at least tdelibs and
tdebase are build correctly before pushing...
16 Mar
16 Mar
9:41 p.m.
New subject: [trinity-devel] CMake × tquic
On Tuesday 15 of March 2016 20:41:00 Slávek Banko wrote:
Dne út 15. března 2016 Fat-Zer napsal(a):
Well, I did a test tdelibs, tdebase, tdepim and tdegames - all successfully.
So it seems that nothing prevents to push patches.
--
Slávek
2016-03-15 17:10 GMT+03:00 Slávek Banko
<slavek.banko(a)axis.cz>cz>:
I tested on tdegames on which I was working. But no problem, I can test
even tdelibs and tdebase.
Thank you. Hi Fat-Zer, all,
I saw that in CMake processing of UIC files is a called command with
redirect of output. I think that's not the ideal way. Therefore, I
propose to modify it so that it will be used CMake method of processing
outputs.
See proposed patch.
Cheers
--
Slávek
Looks fine, but could you please verify that at least tdelibs and
tdebase are build correctly before pushing...
3234
days inactive
3235
days old
4 comments
3 participants
participants (3)
-
Fat-Zer -
Michele Calgaro -
Slávek Banko