Hi Fat-Zer, all,
I saw that in CMake processing of UIC files is a called command with redirect of output. I think that's not the ideal way. Therefore, I propose to modify it so that it will be used CMake method of processing outputs.
See proposed patch.
Cheers
On 03/15/2016 03:10 PM, Slávek Banko wrote:
Hi Fat-Zer, all,
I saw that in CMake processing of UIC files is a called command with redirect of output. I think that's not the ideal way. Therefore, I propose to modify it so that it will be used CMake method of processing outputs.
See proposed patch.
Cheers
Looks good to me. If Alexander is also happy, go ahead and push. Cheers Michele
2016-03-15 17:10 GMT+03:00 Slávek Banko slavek.banko@axis.cz:
Hi Fat-Zer, all,
I saw that in CMake processing of UIC files is a called command with redirect of output. I think that's not the ideal way. Therefore, I propose to modify it so that it will be used CMake method of processing outputs.
See proposed patch.
Cheers
Slávek
Looks fine, but could you please verify that at least tdelibs and tdebase are build correctly before pushing...
Dne út 15. března 2016 Fat-Zer napsal(a):
2016-03-15 17:10 GMT+03:00 Slávek Banko slavek.banko@axis.cz:
Hi Fat-Zer, all,
I saw that in CMake processing of UIC files is a called command with redirect of output. I think that's not the ideal way. Therefore, I propose to modify it so that it will be used CMake method of processing outputs.
See proposed patch.
Cheers
Slávek
Looks fine, but could you please verify that at least tdelibs and tdebase are build correctly before pushing...
I tested on tdegames on which I was working. But no problem, I can test even tdelibs and tdebase.
Thank you.
On Tuesday 15 of March 2016 20:41:00 Slávek Banko wrote:
Dne út 15. března 2016 Fat-Zer napsal(a):
2016-03-15 17:10 GMT+03:00 Slávek Banko slavek.banko@axis.cz:
Hi Fat-Zer, all,
I saw that in CMake processing of UIC files is a called command with redirect of output. I think that's not the ideal way. Therefore, I propose to modify it so that it will be used CMake method of processing outputs.
See proposed patch.
Cheers
Slávek
Looks fine, but could you please verify that at least tdelibs and tdebase are build correctly before pushing...
I tested on tdegames on which I was working. But no problem, I can test even tdelibs and tdebase.
Thank you.
Well, I did a test tdelibs, tdebase, tdepim and tdegames - all successfully. So it seems that nothing prevents to push patches.
-
Fat-Zer -
Michele Calgaro -
Slávek Banko