>I would expect that two systems would be needed--one with HAL but
>not upower etc.) and one with upower and friends (but not HAL).
I don't have an older build system with HAL.
>I am somewhat concerned about cluttering up the tdehwlib files
>with
>conditionals and such, however this may not be an issue once the
>source
>files are split into smaller chunks (e.g. Fat-Zer's work).
>
>On a related note, please do not commit any patches to tdehwlib
>right now
>as I am in the process of merging Fat-Zer's splitting of the
>source files.
Hmm, all of these changes sound like "Stop the presses!" Please
post when the tdehwlib merges and tdebindings/libtqt-perl fixes are
complete. Seems otherwise things will break when attempting to
compile. :-)
Darrell
Using top on my dual core systems during idle periods, kicker,
kmix, and notification-daemon-tde are always at the top of the
CPU%. Typically the numbers hover about 2%. Other Trinity apps
bubble in and out of list yet typically average at 0%.
Are the kicker, kmix, and notification-da values normal for idle
periods?
Darrell
>A few days ago I sent a proposal to add a HAL backend for power
>management. Meanwhile, I fixed call Suspend and added support for
>governor (not tested).
>
>I also noticed that setting the brightness and governor is in
>condition
>WITH_UPOWER, although in fact uses Trinity DBus daemon => has
>nothing to
>do with upower. I added to the option WITH_TDEHWLIB_DAEMONS and
>fixed
>incorrect WITH_UPOWER conditions.
>
>Please test it. At the same time I'm waiting for your opinions -
>incorporate it or not?
To test these improvements, an operating system with HAL installed
is needed?
Darrell
>I's not the session manager changes. It looks like the failure is
>due to
>the changes to the TDEApplication API that allowed Bug 760 to be
>fixed.
>I'll need to see why smoke is failing to parse tdeapplication.h
>(yet
>*again*).
Ok. With libtqt-perl I see this build failure message:
/bin/ld: cannot find -lsmoketqt
Darrell
>Hello,
>
>A few days ago I sent a proposal to add a HAL backend for power
>management. Meanwhile, I fixed call Suspend and added support for
>governor (not tested).
>
>I also noticed that setting the brightness and governor is in
>condition
>WITH_UPOWER, although in fact uses Trinity DBus daemon => has
>nothing to
>do with upower. I added to the option WITH_TDEHWLIB_DAEMONS and
>fixed
>incorrect WITH_UPOWER conditions.
>
>Please test it. At the same time I'm waiting for your opinions -
>incorporate it or not?
Just curious, not trying to make trouble, but do these changes and
the recent TDEApplication API changes mean the hard freeze was
lifted? I don't have a problem with that, I'm just curious of the
project status.
Darrell
>Tim,
>
>With the latest git from today, I see the foolowing build errors:
>
>x_10.cpp:16439:5: error: 'x_TDEApplication::x_TDEApplication(bool,
>
>bool)' cannot be overloaded
>x_10.cpp:16418:5: error: with
>'x_TDEApplication::x_TDEApplication(bool, bool)'
>x_10.cpp:16446:5: error:
>'x_TDEApplication::x_TDEApplication(bool)'
>cannot be overloaded
>x_10.cpp:16425:5: error: with
>'x_TDEApplication::x_TDEApplication(bool)'
>x_10.cpp:16453:5: error: 'x_TDEApplication::x_TDEApplication()'
>cannot be overloaded
>x_10.cpp:16432:5: error: with
>'x_TDEApplication::x_TDEApplication()'
I'm presuming this has something to do with the latest session
manager changes. I was able to build both packages until then.
Darrell
>> Was the release announcement for 3.5.13.2 sent to any media
>folks?
>>
>It was on major russian news feeds dedicated to the opensource
>software.
>Can't say anything about world-wide feeds.
Not exactly helping our own cause. :-(
Darrell
Tim,
k3bhalconnection.cpp:845:70: error: no matching function for call
to 'TDEStorageDevice::mountDevice(const TQString&, TQString&)'
Proposed patch, based upon today's tdebase patch:
diff -urN k3b/libk3bdevice/k3bhalconnection.cpp
k3b.new/libk3bdevice/k3bhalconnection.cpp
--- k3b/libk3bdevice/k3bhalconnection.cpp 2013-04-05
22:32:35.000000000 -0500
+++ k3b.new/libk3bdevice/k3bhalconnection.cpp 2013-08-09
21:35:42.121489109 -0500
@@ -840,9 +840,9 @@
TDEStorageDevice* sdevice =
static_cast<TDEStorageDevice*>(hwdevice);
// FIXME
- // Options from 'options' are not currently loaded into
'optionString'
- TQString optionString;
- TQString mountedPath = sdevice->mountDevice(mountPoint,
optionString);
+ // Options from 'options' are not currently loaded into
'mountOptions'
+ TDEStorageMountOptions mountOptions;
+ TQString mountedPath = sdevice->mountDevice(mountPoint,
mountOptions);
if (mountedPath.isNull()) {
return org_freedesktop_Hal_CommunicationError;
}
@@ -869,8 +869,8 @@
TDEStorageDevice* sdevice =
static_cast<TDEStorageDevice*>(hwdevice);
// FIXME
- // Options from 'options' are not currently loaded into
'optionString'
- TQString optionString;
+ // Options from 'options' are not currently loaded into
'mountOptions'
+ TQString mountOptions;
if (!sdevice->unmountDevice(NULL)) {
// Unmount failed!
The patch allowed be to build k3b, although you know more than me
what is happening.
Darrell
>Looks good, go ahead and push. What is happening is that it was
>brought
>to my attention that the TDE HW library API inadvertently assumed
>the
>usage of pmount in all cases. Therefore, I updated the API to use
>a more
>generic method of specifying mount options; apparently I missed a
>few
>users of the TDE HW library such as k3b.
Pushed in commit 8633f5b9.
Darrell