tde-devels

devels@trinitydesktop.org

3 participants
3807 discussions

Re: [trinity-devel] tdelibs FTBFS
by Darrell Anderson 15 Aug '13

15 Aug '13

>As soon as I saw Tim's commit, it was clear to me that we will >need to add >such a choice. You have prepared a patch or should I do it? I created a patch and am compiling as I write. Here is the patch. Please review! ===================================== diff -urN tdelibs/CMakeLists.txt tdelibs.new/CMakeLists.txt --- tdelibs/CMakeLists.txt 2013-08-15 16:35:14.000000000 -0500 +++ tdelibs.new/CMakeLists.txt 2013-08-15 18:38:21.659877443 -0500 @@ -24,6 +24,7 @@ include( FindPkgConfig ) include( CheckIncludeFile ) +include( CheckIncludeFiles ) include( CheckSymbolExists ) include( CheckFunctionExists ) include( CheckCSourceCompiles ) @@ -94,6 +95,7 @@ OPTION( WITH_SUDO_TDESU_BACKEND "Use sudo as backend for tdesu (default is su)" OFF ) OPTION( WITH_OLD_XDG_STD "Use the pre R14.0.0 XDG standard where both TDE and KDE are recognized in desktop files" OFF ) OPTION( WITH_LZMA "Enable support for LZMA/XZ" ${WITH_ALL_OPTIONS} ) +OPTION( WITH_TDEIOSLAVE_BACKTRACE "Enable backtrace in tdeioslave exception handler" ${WITH_ALL_OPTIONS} ) OPTION( WITH_ASPELL "Enable aspell support" ${WITH_ALL_OPTIONS} ) OPTION( WITH_HSPELL "Enable hspell support" ${WITH_ALL_OPTIONS} ) diff -urN tdelibs/config.h.cmake tdelibs.new/config.h.cmake --- tdelibs/config.h.cmake 2013-08-10 16:36:57.000000000 -0500 +++ tdelibs.new/config.h.cmake 2013-08-15 18:22:48.581678444 -0500 @@ -707,6 +707,9 @@ /* Use FontConfig in tdeinit */ #cmakedefine TDEINIT_USE_FONTCONFIG 1 +/* tdeioslave backtrace */ +#cmakedefine WITH_TDEIOSLAVE_BACKTRACE 1 + /* Use Xft preinitialization in tdeinit */ #cmakedefine TDEINIT_USE_XFT 1 diff -urN tdelibs/tdeio/tdeio/CMakeLists.txt tdelibs.new/tdeio/tdeio/CMakeLists.txt --- tdelibs/tdeio/tdeio/CMakeLists.txt 2013-08-15 16:35:14.000000000 -0500 +++ tdelibs.new/tdeio/tdeio/CMakeLists.txt 2013-08-15 18:32:46.337606197 -0500 @@ -81,13 +81,18 @@ kdirnotify.cpp kdirnotify.skel kdirnotify_stub.cpp observer.cpp ../misc/uiserver.stub observer.skel tdeemailsettings.cpp kprotocolinfo.cpp renamedlg.cpp skipdlg.cpp kremoteencoding.cpp - kmimetypechooser.cpp backtrace_symbols.c + kmimetypechooser.cpp ) +if( WITH_TDEIOSLAVE_BACKTRACE ) + list( APPEND ${target}_SRCS backtrace_symbols.c ) + set( BACKTRACE_LIBRARY bfd ) +endif( ) + tde_add_library( ${target} STATIC_PIC AUTOMOC SOURCES ${${target}_SRCS} DEPENDENCIES dcopidl - LINK bfd + LINK ${BACKTRACE_LIBRARY} bfd ) diff -urN tdelibs/tdeio/tdeio/ConfigureChecks.cmake tdelibs.new/tdeio/tdeio/ConfigureChecks.cmake --- tdelibs/tdeio/tdeio/ConfigureChecks.cmake 1969-12-31 19:00:00.000000000 -0500 +++ tdelibs.new/tdeio/tdeio/ConfigureChecks.cmake 2013-08-15 18:29:10.768715615 -0500 @@ -0,0 +1,17 @@ +################################################# +# +# (C) 2010-2011 Serghei Amelian +# serghei (DOT) amelian (AT) gmail.com +# +# Improvements and feedback are welcome +# +# This file is released under GPL >= 2 +# +################################################# + +if( WITH_TDEIOSLAVE_BACKTRACE ) + check_include_files( "bfd.h;demangle.h;libiberty.h" HAVE_BINUTILS_DEV ) + if( NOT HAVE_BINUTILS_DEV ) + tde_message_fatal( "binutils-dev are required, but not found on your system" ) + endif( ) +endif( ) diff -urN tdelibs/tdeio/tdeio/slavebase.cpp tdelibs.new/tdeio/tdeio/slavebase.cpp --- tdelibs/tdeio/tdeio/slavebase.cpp 2013-08-15 16:35:14.000000000 -0500 +++ tdelibs.new/tdeio/tdeio/slavebase.cpp 2013-08-15 18:35:12.114855058 -0500 @@ -70,6 +70,7 @@ #ifdef HAVE_BACKTRACE void print_trace() { +#ifdef WITH_TDEIOSLAVE_BACKTRACE void *array[10]; size_t size; char **strings; @@ -85,6 +86,7 @@ } free (strings); +#endif } #endif #endif ===================================== Darrell

1 0

Re: [trinity-devel] kstyle-tdestyle renaming --- update
by Darrell Anderson 15 Aug '13

15 Aug '13

>> Am I supposed to push the patch set to git? > >Currently I'll be a few hours away from the computer, so I will >not be able to >promptly deal with any necessary corrections to the Debian/Ubuntu >packaging files. Your reply implies I should push the patches to git. That's fine, just let me know when you are ready and we'll coordinate. I'm not seeing anything here to indicate problems with the patches, but of course, I only use one distro. Regardless, there should not be any major problems, if any at all. Darrell

1 0

Re: [trinity-devel] kstyle-tdestyle renaming --- update
by Darrell Anderson 15 Aug '13

15 Aug '13

On Tue, 13 Aug 2013 19:48:37 -0500 "Timothy Pearson" <kb9vqf(a)pearsoncomputing.net> wrote: >>>>> Should the kstyle directories and files be changed to >tdestyle? >>>>> >>>>Probably. How much would that break at this point though >>>>configuration wise? >>> >>>I don't know. I'm not complaining. :-) I only noticed the >>>differences when I was responding to bug report 1609. Seems we >>>have >>>moved far with so much renaming and of late we have continued >some >>> >>>mopping up of those efforts. :-) >>> >>>A quick scan of modules that install files to >>>$PREFIX/share/apps/kstyle: >>> >>>tdelibs >>>tdebase >>>tdeartwork >>>tdesdk >>> >>>I don't have all packages installed right now so there might be >a >>>few more. >>> >>>Other loose ends include renaming $TDEHOME/share/apps/kstyle- >>>>tdestyle, where ever that is defined (tdelibs?), and r14-xdg- >>>update. Probably other loose ends too. >>> >>>I notice when grepping the sources some internal functions of >>>kstyle* still exist. tdebase/kpersonalizer has cpp files with >>>kstyle8. >>> >>>I could hammer out and test the patches. The grunt work of the >>>patches should go fine, but I'd need a some days of validating >>>build runs and usability testing. If I get overwhelmed I holler. >>>Probably first scream and cry, but eventually holler. :-) >> >> Creating patches went surprisingly smooth. The final list is >short: >> >> tdelibs >> tdebase >> tdeartwork >> tdesdk >> tde-style-lipstik >> tde-style-qtcurve >> koffice >> tde-i18n >> >> I had no build errors. A superficial test of selecting the >styles >> in kcontrol resulted in no errors or problems. >> >> Caveat: The tde-i18n patch is huge. So huge that I will not even >> try to post the patch or try to push to git until I reduce to >> smaller patches and push piece-meal one at a time. >> >> That said, how do we want to proceed next? I can post the >patches >> online and somebody else could test. Or I could just push to git >> and listen for screams of pain and anguish. No problems noticed >> here, but I'm only one person with my own perspective. >> >> Darrell > >Slavek, can you handle updating the Debian/Ubuntu packaging files >for this change? Am I supposed to push the patch set to git? Darrell

2 1

Re: [trinity-devel] Valgrind
by Darrell Anderson 15 Aug '13

15 Aug '13

>Whenever an application misbehaves in an unusual manner (e.g. >platform >dependent, working one day and not another, etc.) I generally run >it under >Valgrind to see if there are any memory corruption issues. >Otherwise, for >fun I sometimes load applications under Valgrind, but that is the >extent >of the QA in this area. Is there anything we can do to supplement that kind of approach? I'm no valgrind expert at all. Just curious whether we can help Trinity with valgrind. Darrell

1 0

Automated qt3->tqt3 updates
by Darrell Anderson 15 Aug '13

15 Aug '13

I see some qt3 updates in the commit list web page for bug report 1350. I am able to pull those changes. I am not seeing any changes in tqt3 to pull. Is the automated tqt3 script functioning? Darrell

3 5

Valgrind
by Darrell Anderson 15 Aug '13

15 Aug '13

I read an article today abut using Valgrind to test software code. Do we perform any such tests for Trinity? If not then how could we start such a program? Darrell

2 1

Re: [trinity-devel] ktorrent and avahi
by Darrell Anderson 14 Aug '13

14 Aug '13

>I've attached it. If I'm reading it correctly, once it's applied, >you pass --without-avahi to disable the relevant code. I updated the patch for the tqt framework. I tested with avahi/avahi-tqt installed and not installed. Looks great. I'll push to git. Note to all: the defaults remain the same. As mentioned, --disable- avahi must be explicitly defined in the configuration. Otherwise nothing changes --- even the configuration warnings remain the same when avahi is not found and will not be compiled. Thanks! Darrell

1 0

Re: [trinity-devel] kstyle-tdestyle renaming --- update
by Darrell Anderson 14 Aug '13

14 Aug '13

>> >btw: haven't forgot to rename cmake variables? e.g. in >> >tdeartwork... >> >> Is that a question? To me? >> >Um... yes,,,, why are you so mush surprised? >During most of previous renames, I noticed, the cmake options were >left-behind, No, I wasn't surprised. I just did not understand the question. If you mean, did I remember to update the CMakeLists.txt files, yes. :- ) As I mentioned, everything built without error, everything installed to $PREFIX/share/apps/tdestyle, and there is no remnant $PREFIX/share/apps/kstyle after updating the packages. Typically though I tend to forget to run 'git add --all' before creating the commit message. I know better --- but there isn't a sufficiently hefty 2x4 here to sometimes remind me. :-) Darrell

1 0

Re: [trinity-devel] kstyle-tdestyle renaming --- update
by Darrell Anderson 14 Aug '13

14 Aug '13

>> Caveat: The tde-i18n patch is huge. So huge that I will not even >> try to post the patch or try to push to git until I reduce to >> smaller patches and push piece-meal one at a time. Woops! A typo in my diff command resulted in the large diff. The final patch is now MUCH smaller and sane. :-) >I don't feel that I'm one of core testers, but why not to push >them into >their own branch and let somebody test it? >IMO It's easier than mess with patch-sets and no mob of angry >developers or >testers will not want to broke your legs ;) Branch? Um, nope, ain't going down that road. :-) Git hates me and I hate git. I'm reasonably confident the patch set can be pushed to git as is because I'm seeing no problems here. I asked the question of posting patches for testing in case others don't feel confident, which I'm fine with. >btw: haven't forgot to rename cmake variables? e.g. in >tdeartwork... Is that a question? To me? Darrell

2 1

Re: [trinity-devel] kstyle-tdestyle renaming --- update
by Darrell Anderson 14 Aug '13

14 Aug '13

>>> Should the kstyle directories and files be changed to tdestyle? >>> >>Probably. How much would that break at this point though >>configuration wise? > >I don't know. I'm not complaining. :-) I only noticed the >differences when I was responding to bug report 1609. Seems we >have >moved far with so much renaming and of late we have continued some > >mopping up of those efforts. :-) > >A quick scan of modules that install files to >$PREFIX/share/apps/kstyle: > >tdelibs >tdebase >tdeartwork >tdesdk > >I don't have all packages installed right now so there might be a >few more. > >Other loose ends include renaming $TDEHOME/share/apps/kstyle- >>tdestyle, where ever that is defined (tdelibs?), and r14-xdg- >update. Probably other loose ends too. > >I notice when grepping the sources some internal functions of >kstyle* still exist. tdebase/kpersonalizer has cpp files with >kstyle8. > >I could hammer out and test the patches. The grunt work of the >patches should go fine, but I'd need a some days of validating >build runs and usability testing. If I get overwhelmed I holler. >Probably first scream and cry, but eventually holler. :-) Creating patches went surprisingly smooth. The final list is short: tdelibs tdebase tdeartwork tdesdk tde-style-lipstik tde-style-qtcurve koffice tde-i18n I had no build errors. A superficial test of selecting the styles in kcontrol resulted in no errors or problems. Caveat: The tde-i18n patch is huge. So huge that I will not even try to post the patch or try to push to git until I reduce to smaller patches and push piece-meal one at a time. That said, how do we want to proceed next? I can post the patches online and somebody else could test. Or I could just push to git and listen for screams of pain and anguish. No problems noticed here, but I'm only one person with my own perspective. Darrell

3 2

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

tde-devels