tde-devels

devels@trinitydesktop.org

6 participants
3856 discussions

tqt-replace, Q_SLOTS et al, and non-cmake projects
by Nix 11 Jun '12

11 Jun '12

So my attempted build of kdeaccessibility is failing. The failure is because of Q_SLOTS: nothing is replacing it with <slots> before processing by uic, so uic is never putting the slot into the .h file and compilation is failing. While tqt-replace fixes this up for projects using CMake, the corresponding call in am_edit was commented out in July 2010, in this commit: commit 4f9a36e2fcee4ecd7adbc3e53c8e6837712c2a35 Author: tpearson <tpearson@283d02a7-25f6-0310-bc7c-ecb5cbfe19da> Date: Mon Jul 26 02:04:25 2010 +0000 First attempt at getting TQT integrated... But even with that commented-out tqt-replace call uncommented, it still doesn't work. If we look at kaccessibility/kmouth/wordcompletion/Makefile, we see: all: docs-am all-am all-am: Makefile $(LIBRARIES) LIBRARIES = $(noinst_LIBRARIES) noinst_LIBRARIES = libwordcompletion.a libwordcompletion.a: $(libwordcompletion_a_OBJECTS) $(libwordcompletion_a_DEPENDENCIES) $(EXTRA_libwordcompletion_a_DEPENDENCIES) libwordcompletion_a_OBJECTS = $(libwordcompletion_a_nofinal_OBJECTS) libwordcompletion_a_OBJECTS = $(libwordcompletion_a_nofinal_OBJECTS) #libwordcompletion_a_OBJECTS = $(libwordcompletion_a_final_OBJECTS) libwordcompletion_a_final_OBJECTS = libwordcompletion_a.all_cpp.o and it is the libwordcompletion_a.all_cpp.o rule that has the tqt-replace call in it. Thus, this is only going to work if that line is uncommented *and* --enable-final is passed in. But the Wiki doesn't mention --enable-final, only --enable-closure! Unfortunately that *also* doesn't work, and it becomes obvious why Tim commented that line out -- it's applying to the .cpp files only, but to be effective tqt-replace must run over the .ui files, before uic gets to them. I don't see how this could possibly ever work. Have people actually managed to compile the non-cmake parts of Trinity in the last little while? If so, what configure flags did you use, and could you send me a copy of kaccessibility/kmouth/wordcompletion/Makefile.in and kaccessibility/kmouth/wordcompletion/wordcompletionui.{everything but .o and .lo} after a build? 'cos I am sore confused. Ditching this whole nightmare and going to cmake is ever such a good idea! :) -- NULL && (void)

1 0

[PATCH tdenetwork 4/4] The propsdlgplugin must depend on filesharesamba.
by Nix 11 Jun '12

11 Jun '12

propertiespage.cpp in this plugin references one of the UIC headers in filesharesamba, so filesharesamba must be compiled first. --- filesharing/advanced/propsdlgplugin/CMakeLists.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/filesharing/advanced/propsdlgplugin/CMakeLists.txt b/filesharing/advanced/propsdlgplugin/CMakeLists.txt index f6477d1..26d94f5 100644 --- a/filesharing/advanced/propsdlgplugin/CMakeLists.txt +++ b/filesharing/advanced/propsdlgplugin/CMakeLists.txt @@ -32,6 +32,7 @@ install( FILES tde_add_library( propsdlgplugin_common STATIC_PIC AUTOMOC SOURCES propertiespage.cpp propertiespagegui.ui + DEPENDENCIES filesharesamba ) -- 1.7.10.4.153.g8c399cf

3 8

default.kde?
by Darrell Anderson 11 Jun '12

11 Jun '12

While finding and testing the various files in the icon themes that needed branding updates, I noticed a sym link named default.kde pointing to crystalsvg. Seems as long as we are trying to catch various branding issues and avoid potential conflicts with KDE, that the sym link should be renamed to default.tde. Looks like the following apps need nominal patching: kile tde-style-qtcurve kmymoney tdepim tdelibs tdebindings tdebase (docbook reference) tde-i18n (docbook references) Any objections to patching? Darrell

2 2

Oops! Exit status dialog image is KDE
by Darrell Anderson 11 Jun '12

11 Jun '12

Has anybody tested exiting Trinity with different icon sets? The exit status dialog image looks great with the crystalsvg icon set. When used with other icons set the image is KDE rather than TDE. Oops! :-) Affected icon sets: kdeclassic kids monochrome slick Does anybody know which images the exit status dialog grabs so we can update the images? E. Liddell --- looks like your wonderful art talents will be needed again! Darrell

4 35

[PATCH tdenetwork 3/4] Fix a silly typo in the SMS protocol code.
by Nix 10 Jun '12

10 Jun '12

--- kopete/protocols/sms/services/smsclient.cpp | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/kopete/protocols/sms/services/smsclient.cpp b/kopete/protocols/sms/services/smsclient.cpp index 9fb5a92..984e843 100644 --- a/kopete/protocols/sms/services/smsclient.cpp +++ b/kopete/protocols/sms/services/smsclient.cpp @@ -59,7 +59,7 @@ void SMSClient::send(const Kopete::Message& msg) m_msg = msg; KConfigGroup* c = m_account->configGroup(); - TQString provider = c->readEntry(TQString("%1:%2").arg("SMSClient").arg("ProviderName"); + TQString provider = c->readEntry(TQString("%1:%2").arg("SMSClient").arg("ProviderName")); if (provider.isNull()) { @@ -67,7 +67,7 @@ void SMSClient::send(const Kopete::Message& msg) return; } - TQString programName = c->readEntry(TQString("%1:%2").arg("SMSClient").arg("ProgramName"); + TQString programName = c->readEntry(TQString("%1:%2").arg("SMSClient").arg("ProgramName")); if (programName.isNull()) programName = "/usr/bin/sms_client"; @@ -97,14 +97,14 @@ TQWidget* SMSClient::configureWidget(TQWidget* parent) prefWidget->configDir->setMode(KFile::Directory); TQString configDir; if (m_account) - configDir = m_account->configGroup()->readEntry(TQString("%1:%2").arg("SMSClient").arg("ConfigDir"); + configDir = m_account->configGroup()->readEntry(TQString("%1:%2").arg("SMSClient").arg("ConfigDir")); if (configDir.isNull()) configDir = "/etc/sms"; prefWidget->configDir->setURL(configDir); TQString programName; if (m_account) - programName = m_account->configGroup()->readEntry(TQString("%1:%2").arg("SMSClient").arg("ProgramName"); + programName = m_account->configGroup()->readEntry(TQString("%1:%2").arg("SMSClient").arg("ProgramName")); if (programName.isNull()) programName = "/usr/bin/sms_client"; prefWidget->program->setURL(programName); -- 1.7.10.4.153.g8c399cf

1 0

[PATCH tdenetwork 2/4] Compile without V4L1 headers.
by Nix 10 Jun '12

10 Jun '12

These don't exist in recent Linux kernels. No V4L2 support yet, so you don't get video, and you have to remember to disable the motionautoaway plugin, but at least kopete builds again. --- kopete/ConfigureChecks.cmake | 7 +++++++ kopete/libkopete/avdevice/videocontrol.h | 2 -- kopete/libkopete/avdevice/videodevice.cpp | 2 -- kopete/libkopete/avdevice/videodevice.h | 10 +++++++--- kopete/libkopete/avdevice/videodevicepool.cpp | 2 -- kopete/libkopete/avdevice/videoinput.h | 2 -- 6 files changed, 14 insertions(+), 11 deletions(-) diff --git a/kopete/ConfigureChecks.cmake b/kopete/ConfigureChecks.cmake index aece436..70e97f5 100644 --- a/kopete/ConfigureChecks.cmake +++ b/kopete/ConfigureChecks.cmake @@ -26,3 +26,10 @@ if ( HAVE_LIBV4L1_VIDEODEV_H ) endif ( ) # -- End libv4l1-videodev.h ---------------------------------------------- +# -- Check for linux/videodev.h presence -------------------- +CHECK_INCLUDE_FILE ( "linux/videodev.h" HAVE_LINUX_VIDEODEV_H ) +if ( HAVE_LINUX_VIDEODEV_H ) + add_definitions( -DHAVE_LINUX_VIDEODEV_H ) +endif ( ) +# -- End linux-videodev.h ---------------------------------------------- + diff --git a/kopete/libkopete/avdevice/videocontrol.h b/kopete/libkopete/avdevice/videocontrol.h index c4db3b9..dbef6b5 100644 --- a/kopete/libkopete/avdevice/videocontrol.h +++ b/kopete/libkopete/avdevice/videocontrol.h @@ -15,8 +15,6 @@ ************************************************************************* */ -#define ENABLE_AV - #ifndef KOPETE_AVVIDEOCONTROL_H #define KOPETE_AVVIDEOCONTROL_H diff --git a/kopete/libkopete/avdevice/videodevice.cpp b/kopete/libkopete/avdevice/videodevice.cpp index ea23544..e12fb02 100644 --- a/kopete/libkopete/avdevice/videodevice.cpp +++ b/kopete/libkopete/avdevice/videodevice.cpp @@ -15,8 +15,6 @@ ************************************************************************* */ -#define ENABLE_AV - #include <cstdlib> #include <cerrno> #include <cstring> diff --git a/kopete/libkopete/avdevice/videodevice.h b/kopete/libkopete/avdevice/videodevice.h index 7bba507..7e57513 100644 --- a/kopete/libkopete/avdevice/videodevice.h +++ b/kopete/libkopete/avdevice/videodevice.h @@ -15,11 +15,11 @@ ************************************************************************* */ -#define ENABLE_AV - #ifndef KOPETE_AVVIDEODEVICELISTITEM_H #define KOPETE_AVVIDEODEVICELISTITEM_H +#define ENABLE_AV + #if defined HAVE_CONFIG_H #include <config.h> #endif @@ -54,8 +54,10 @@ #include <linux/kernel.h> #if defined(HAVE_LIBV4L1_VIDEODEV_H) #include <libv4l1-videodev.h> -#else +#elif defined(HAVE_LINUX_VIDEODEV_H) #include <linux/videodev.h> +#else +#undef ENABLE_AV #endif #define VIDEO_MODE_PAL_Nc 3 #define VIDEO_MODE_PAL_M 4 @@ -293,8 +295,10 @@ public: void enumerateMenu (void); #endif +#ifndef ENABLE_AV struct video_capability V4L_capabilities; struct video_buffer V4L_videobuffer; +#endif #endif TQValueVector<Kopete::AV::VideoInput> m_input; TQValueVector<Kopete::AV::VideoControl> m_control; diff --git a/kopete/libkopete/avdevice/videodevicepool.cpp b/kopete/libkopete/avdevice/videodevicepool.cpp index b725d5d..cbfe7cb 100644 --- a/kopete/libkopete/avdevice/videodevicepool.cpp +++ b/kopete/libkopete/avdevice/videodevicepool.cpp @@ -15,8 +15,6 @@ ************************************************************************* */ -#define ENABLE_AV - #include <assert.h> #include <cstdlib> #include <cerrno> diff --git a/kopete/libkopete/avdevice/videoinput.h b/kopete/libkopete/avdevice/videoinput.h index 9fc109a..dd7504f 100644 --- a/kopete/libkopete/avdevice/videoinput.h +++ b/kopete/libkopete/avdevice/videoinput.h @@ -15,8 +15,6 @@ ************************************************************************* */ -#define ENABLE_AV - #ifndef KOPETE_AVVIDEOINPUT_H #define KOPETE_AVVIDEOINPUT_H -- 1.7.10.4.153.g8c399cf

1 0

[PATCH tdenetwork 1/4] tde_message_error should be tde_message_fatal.
by Nix 10 Jun '12

10 Jun '12

tde_message_error does not exist, making the resulting error less than helpful. --- kopete/plugins/netmeeting/CMakeLists.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kopete/plugins/netmeeting/CMakeLists.txt b/kopete/plugins/netmeeting/CMakeLists.txt index b6cc031..318b672 100644 --- a/kopete/plugins/netmeeting/CMakeLists.txt +++ b/kopete/plugins/netmeeting/CMakeLists.txt @@ -10,7 +10,7 @@ ################################################# if( NOT BUILD_KOPETE_PROTOCOL_MSN ) - tde_message_error( "netmeeting plugin needs msn protocol.\n Add -DBUILD_KOPETE_PROTOCOL_MSN=ON to cmake flags." ) + tde_message_fatal( "netmeeting plugin needs msn protocol.\n Add -DBUILD_KOPETE_PROTOCOL_MSN=ON to cmake flags." ) endif( ) include_directories( -- 1.7.10.4.153.g8c399cf

1 0

A bunch of trunk build patches coming
by Nix 10 Jun '12

10 Jun '12

So I just tried to migrate to trinity (from trunk as of two days ago, before the latest round of renaming patches). To keep things neat I'm sticking the whole thing excepting tqtinterface into a tree rooted at /usr/trinity/ (henceforward '$trinity_root'). I've built up to tdebase, I've noticed the following build problems (patches follow fixing those for which fixes seem practical). Non-build problems are mostly not mentioned here because I haven't restarted into TDE yet (I want to get more built before then). - If you install tqtinterface as suggested on the wiki, avahi-tqt fails to build: make[2]: Entering directory `/usr/src/kde/trinity/main/dependencies/x86_64-spindle/avahi-tqt' /usr/trinity/bin/moc moc qt-watch.cpp qt-watch.moc3 TQt meta object compiler moc: Too many input files specified This is in part because moc-tqt cannot be found. If we follow the wiki's instructions and install tqtinterface in /usr, it ends up in a different place from TQt and the configure-time search for tmoc fails. Moving tqtinterface into the $trinity_root fixes that, but then the hardwired -I/usr/include/tqt is wrong and the build fails again. The only fix I've found is to install tqtinterface into the $trinity_root, and then symlink /usr/include/tqt to that location. This is, not to put too fine a point on it, insane. I note that even if you *do* install tqtinterface into the $trinity_root, the pkg-config file ends up in ${prefix}/pkgconfig. This appears to be intentional, but is quite mystifying given that all you need to do to avoid it is to set PKG_CONFIG_PATH, which must be set anyway or the build of tqtinterface will fail (because qt-mt.pc is not in /usr/lib/pkgconfig but rather in $trinity_root/lib/pkgconfig.) Is the expectation nowadays that tqt3 is installed in /usr as well, or is this a bug? (I don't have a patch for this because I can't think of a non-insane fix.) - in konsole, meta is not recognized (only alt is). I have a pre-existing patch for this ancient KDE problem. - covariant return type checking is broken, because it's using the C compiler rather than the C++ compiler :) but even if that is fixed, the check still fails, because... - in the cmake FindTQt module, most of the CXXFLAGS are being missed out, leading to spurious failures in CheckCXXSourceRuns. Patches for the latter three problems follow (not as a single git patch series, though, because I can't figure out how to make one of those crossing multiple submodules: anyone?) -- NULL && (void)

2 2

update default - konqueror>Preview&Metadata>Maximum file size = 10M
by David C. Rankin 10 Jun '12

10 Jun '12

Darrell, Can we increase this default to about 10M? 1M is for 10 years ago :) -- David C. Rankin, J.D.,P.E.

2 5

Mime files in /opt/trinity/lib/mime
by Slávek Banko 10 Jun '12

10 Jun '12

Hi all, Chromium on my machine suddenly began to open PDF files in the GV. I began to wonder why and found that they follow entries in the file /etc/mailcap. It is generated automatically by update-mime using files in /usr/lib/mime. But some files are installed into /opt/trinity/lib/mime. I think we should fix that instead of /opt/trinity/lib/mime were all installed in /usr/lib/mime. What do you think? Slavek --

5 10

Jump to page:

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

tde-devels