On 04/05/2012 10:59 AM, Darrell Anderson wrote:
I don't understand. The patch only change qDebug and qWarning, not any "iterator" functions or lines.
Darrell
Hmm - that makes two of us. Nothing makes sense right now :( I see that the changes only affected the lines around 'TQListViewItemIterator it' and not the iterator itself. Grepping it looks like the gpssyncdialog.cpp and imageslist.cpp both contain the same declaration, but if it is limited to file scope that shouldn't matter:
12:55 archangel:/dat_e/chroot/david/build/src/kipi-plugins> grep -r 'TQListViewItemIterator it' * kipi-plugins/kameraklient/camerafolderview.cpp: TQListViewItemIterator it(this); kipi-plugins/kameraklient/setupcamera.cpp: TQListViewItemIterator it(listView_); kipi-plugins/ipodexport/ipodexportdialog.cpp: TQListViewItemIterator it2( m_uploadList ); kipi-plugins/gpssync/gpssyncdialog.cpp: TQListViewItemIterator it( d->listView ); kipi-plugins/gpssync/gpssyncdialog.cpp: TQListViewItemIterator it( d->listView ); kipi-plugins/gpssync/gpssyncdialog.cpp: TQListViewItemIterator it(d->listView); kipi-plugins/gpssync/gpssyncdialog.cpp: TQListViewItemIterator it(d->listView); kipi-plugins/gpssync/gpssyncdialog.cpp: TQListViewItemIterator it( d->listView ); kipi-plugins/gpssync/gpssyncdialog.cpp: TQListViewItemIterator it(d->listView); kipi-plugins/rawconverter/batchdialog.cpp: TQListViewItemIterator it( m_listView ); kipi-plugins/rawconverter/batchdialog.cpp: TQListViewItemIterator it( m_listView ); kipi-plugins/batchprocessimages/batchprocessimagesdialog.cpp: TQListViewItemIterator it2( m_listFiles ); kipi-plugins/flickrexport/imageslist.cpp: TQListViewItemIterator it(d->listView); kipi-plugins/flickrexport/imageslist.cpp: TQListViewItemIterator it(d->listView); kipi-plugins/flickrexport/imageslist.cpp: TQListViewItemIterator it(d->listView); kipi-plugins/flickrexport/imageslist.cpp: TQListViewItemIterator it(d->listView); kipi-plugins/flickrexport/imageslist.cpp: TQListViewItemIterator it(d->listView);
But when it gets to the imagelist.cpp build, gcc is complaining that it has 2 declarations for 'TQListViewItemIterator it'???
libtool: compile: g++ -DHAVE_CONFIG_H -I. -I../.. -I/opt/trinity/include -I/opt/trinity/include -I../../kipi-plugins/common/include -I/opt/trinity/include -I/opt/trinity/include -I/opt/tqt3/include -I. -include tqt.h -I/opt/trinity/include/tde -DQT_THREAD_SUPPORT -D_REENTRANT -Wno-long-long -Wundef -ansi -D_XOPEN_SOURCE=500 -D_BSD_SOURCE -Wcast-align -Wchar-subscripts -Wall -W -Wpointer-arith -fno-builtin -g3 -fno-inline -march=x86-64 -mtune=generic -O2 -pipe -fstack-protector --param=ssp-buffer-size=4 -D_FORTIFY_SOURCE=2 -fpermissive -fpermissive -Wformat-security -Wmissing-format-attribute -Wno-non-virtual-dtor -fno-exceptions -fno-check-new -fno-common -I/usr/include/tqt -DQT_CLEAN_NAMESPACE -DQT_NO_ASCII_CAST -DQT_NO_STL -DQT_NO_COMPAT -DQT_NO_TRANSLATION -MT imageslist.lo -MD -MP -MF .deps/imageslist.Tpo -c imageslist.cpp -fPIC -DPIC -o .libs/imageslist.o In file included from /opt/trinity/include/kfileitem.h:31:0, from /opt/trinity/include/kio/previewjob.h:27, from imageslist.cpp:42: /opt/trinity/include/kfilemetainfo.h:1237:34: warning: type qualifiers ignored on function return type [-Wignored-qualifiers] imageslist.cpp: In member function 'void KIPIFlickrExportPlugin::ImagesList::slotAddImages(const KURL::List&)': imageslist.cpp:231:35: error: redeclaration of 'TQListViewItemIterator it' imageslist.cpp:223:36: error: 'TQValueList<KURL>::const_iterator it' previously declared here
I think your patch is in the clear, it looks like this will be another gcc 4.7 present...