On Monday 14 of July 2014 02:49:11 Timothy Pearson wrote:
On Sun July 13 2014 7:01:24 pm Timothy Pearson wrote:
I forgot to declare resizeEvent and showEvent as virtual void in amarok/src/systray.h; I haven't yet tested if fixing this will repair the regression. Aside from this slip-up I don't see anything in that commit that should affect the menu options whatsoever.
If you want to try adding the missing virtual keyword to those two methods please let me know if it fixes the problem. Otherwise I'll try to track this down tomorrow when I have more time.
The following patch does not resolve the missing menu:
diff -urN amarok/amarok/src/systray.h amarok.new/amarok/src/systray.h --- amarok/amarok/src/systray.h 2014-07-09 19:52:56.000000000 -0500 +++ amarok.new/amarok/src/systray.h 2014-07-13 19:26:44.506064803 -0500 @@ -30,8 +30,8 @@ virtual void engineTrackPositionChanged( long position, bool /*userSeek*/ ); // get notified of 'highlight' color change virtual void paletteChange( const TQPalette & oldPalette );
- void resizeEvent ( TQResizeEvent * );
- void showEvent ( TQShowEvent * );
- virtual void resizeEvent ( TQResizeEvent * );
- virtual void showEvent ( TQShowEvent * );
private: bool event( TQEvent* );
Darrell
OK, thanks for testing.
Slavek, can you see any way that this commit could have affected the tray icon menu? https://git.trinitydesktop.org/cgit/amarok/commit/?id=f3088bc3de7db3d3bf523 4cb8327b2bfa1e0a025
Thanks!
Tim
Yes, I can look at it, but later - now I have time to go to sleep :)