25 Jun
2012
25 Jun
'12
3:06 p.m.
On 06/25/2012 05:01 PM, David C. Rankin wrote:
Without knowing more, this looks like it might
cripple amarok's ability to
look up all the song, artist info online. My guess is that the CD_Lookup_Tool
probably provides the replacement. It may already be implemented, but this is
the first time I've run into the issue and Amarok was working with the old
tunepimp dependency up until this round of builds.
grepping the git tree, it looks like the following is where the impact will be
in the current code:
ktrm.cpp:#include <tunepimp-0.5/tp_c.h>
ktrm.cpp:#include <tunepimp/tp_c.h>
ktrm.cpp: static void TRMNotifyCallback(tunepimp_t pimp, void *data,
TPCallbackEnum type, int fileId, TPFileStatus status);
ktrm.cpp: static void TRMNotifyCallback(tunepimp_t pimp, void *data,
TPCallbackEnum type, int fileId);
ktrm.cpp: const tunepimp_t &tunePimp() const
ktrm.cpp: TQString tunepimpHost = TQString(server);
ktrm.cpp: TQString tunepimpHostWithPort = (tunepimpHost +
":%1").arg(port);
ktrm.cpp: if(normalizedHost == tunepimpHost ||
ktrm.cpp: tunepimpHost.endsWith('.' + normalizedHost)) {
ktrm.cpp: if(normalizedHost == tunepimpHostWithPort ||
ktrm.cpp: tunepimpHostWithPort.endsWith('.' + normalizedHost))
{
ktrm.cpp: tunepimp_t m_pimp;
ktrm.cpp:static void TRMNotifyCallback(tunepimp_t /*pimp*/, void */*data*/,
TPCallbackEnum type, int fileId, TPFileStatus status)
ktrm.cpp:static void TRMNotifyCallback(tunepimp_t pimp, void */*data*/,
TPCallbackEnum type, int fileId)
ktrm.h: * An abstraction for libtunepimp's TRM based lookup and file recognition.
--
David C. Rankin, J.D.,P.E.