On Friday 18 November 2011 23:27:46 Timothy Pearson wrote:
On Friday 18 November 2011 21:32:49 Timothy Pearson wrote: [...]
OK, looks like someone is going to have to create a CMake patch to add libcrypt detection in order for this to work. Problem is the partial GIT migration and KDE-->TDE make it quite difficult for me to do at this time.
I think is useless to detect libcrypt, because it is part of libc, we can assume that any system based on libc have this library.
Serghei, do you think you could whip something up based on the 3.5.13 sources?
Sorry, I did not understood this sentence :) Please rephrase it.
Sorry about that. Can you create a patch for the TDE CMake files, based on the TDE v3.5.13 source tarballs, that enables the libcrypt-dependent code in kdebase? Right now the libcrypt-dependent code is disabled when built under CMake because of an unset C++ #define and a missing linker flag.
Sure, I will do this.
I forgot to add that other TDE modules may expect to see HAVE_CRYPT defined as well, so it would probably be a good idea to pass HAVE_CRYPT as a #define to all TDE modules (i.e. add the fix the CMake code in the common cmake/ directory, not just to the CMake modules in kdebase).
Hmm, it will be a useless check when crypt is not needed. I think we should identify modules which need HAVE_CRYPT.
Tim