24 Sep
2016
24 Sep
'16
9:37 a.m.
Michele Calgaro wrote:
Hi,
yes it is working. The level is according to the bug description, so this
functionality is covered.
The note I wrote is for future improvement. This won't be done in this bug.
Feel free to test and commit.
regards
On 2016/09/24 07:32 PM, deloptes wrote:
> Yes, indeed it was a good exercise.
> I uploaded 2 patches for the plugin code and for the debian installer.
> Tested OK.
>
> The only think I dislike here is that the granularity is set to 3 but the
> step can be only 1. It gets ugly when you go for value < 1.
>
>
https://api.kde.org/3.5-api/kdelibs-apidocs/kdeui/html/classKDoubleSpinBox.…
>
https://api.kde.org/3.5-api/kdelibs-apidocs/kdeui/html/knuminput_8cpp_sourc…
IMO it should depend on the size and unit, but lets leave some work for
the future. We could open a new bug to fix this later.
If someone can test more of it, it would be great.
regards
So is the patch finally working on your system? If so, I will try to test
this week, perhaps even tomorrow. Please confirm.
If it is still not working/finalized, I will delay testing it until you
have a newer version. Reason being that the time for TDE is little and I
try to do the best of it ;-)
PS: thank you all for the patience and good
mentoring so far.
You are welcome :-) Thanks for having joined the development
team!!