gtk3-tqt-engine FTBFS on debian/testing, complaining that ld can't find libtdeui. Attached proposed patch.
Cheers Michele
On Friday 13 of September 2013 08:46:58 Michele Calgaro wrote:
gtk3-tqt-engine FTBFS on debian/testing, complaining that ld can't find libtdeui. Attached proposed patch.
Cheers Michele
Good point. I have not found anywhere definition of any TDEGTK_* variables. So, all these variables seems to be suitable to replace.
Slavek --
Da: Slávek Banko slavek.banko@axis.cz
gtk3-tqt-engine FTBFS on debian/testing, complaining that ld can't find libtdeui. Attached proposed patch.
Good point. I have not found anywhere definition of any TDEGTK_* variables. So, all these variables seems to be suitable to replace.
Correct Slavek, TDEGTK_* seems not to be defined anywhere. That's why I replaced TDEGTK_LDFLAGS instead of adding KDE_LDFLAGS on the same line. I think we should either: - replace the KDE_* definitions with equivalent TDEGTK_* ones or - remove the TDEGTK_* definitions and use only the KDE_* one. Personally I would choose the first option, even though it may require more changes. But I leave the decisions to the "gurus" :)
Cheers Michele
Dne po 16. září 2013 Michele Calgaro napsal(a):
Da: Slávek Banko slavek.banko@axis.cz
gtk3-tqt-engine FTBFS on debian/testing, complaining that ld can't find libtdeui. Attached proposed patch.
Good point. I have not found anywhere definition of any TDEGTK_* variables. So, all these variables seems to be suitable to replace.
Correct Slavek, TDEGTK_* seems not to be defined anywhere. That's why I replaced TDEGTK_LDFLAGS instead of adding KDE_LDFLAGS on the same line. I think we should either:
- replace the KDE_* definitions with equivalent TDEGTK_* ones or
- remove the TDEGTK_* definitions and use only the KDE_* one.
Personally I would choose the first option, even though it may require more changes. But I leave the decisions to the "gurus" :)
Cheers Michele
I think that TDEGTK_* would be equally simple composition KDE_* and GTK3_* definitions. And because probably similar composition is not used in any other module, I prefer keeping separate KDE_* and GTK3_* definitions => replace TDEGTK_* to KDE_*.
Slavek --
-
Michele Calgaro -
Slávek Banko