14 Dec
2012
14 Dec
'12
4:55 a.m.
Hi there,
sip4-tqt FTBFS on my computer (debian/testing). I used the most recent GIT sources for
both TDE and
TDE-packaging (2012/12/14).
The problem is in compiling the sipgen module, when the sip.h file is not found.
> gcc -c -O2 -g -I/usr/include/tqt
-I/usr/include/tqt3 -I/usr/include/qt3 -w -DNDEBUG -I. -o parser.o parser.c
> /home/tde_src/2_build/build/dependencies/sip4-tqt/sipgen/parser.y:24:17: fatal error:
sip.h: No such file or directory
The patch adds the module source folder to the include path when generating the
makefiles.
-------------------
In the GIT repo, there is a file siputils.py.orig in the dependencies/sip4-tqt folder. I
guess this is a left over from a previous change and it could be removed.
-------------------
On a side note, what's the standard procedure followed by the TDE team members for
submitting bug
fixes/improvements? Should we post patches to this ML or is there another way? Or should
we just commit
that to the GIT repo?
Cheers
Michele
14 Dec
14 Dec
5:32 a.m.
New subject: [trinity-devel] sip4-tqt FTBFS (debian/testing). Quit patch.
Hi there,
<snip>
-------------------
On a side note, what's the standard procedure followed by the TDE team
members for submitting bug
fixes/improvements? Should we post patches to this ML or is there another
way? Or should we just commit
that to the GIT repo?
In general there are two ways to tosubmit patches:
1.) Submit a patch to the mailing list for ACK/NAK before committing to GIT
-OR-
2.) File a bug report and attach the patch to it
In general, small patches that fix build failures and other minor defects
should just be sent to the list and committed to GIT if no one objects.
Larger patches, such as those which change library ABIs and/or user
interfaces should be attached to a bug report which details the defect
encountered and the subsequent reasoning behind the patch.
Hope this helps!
Tim
5:42 a.m.
New subject: [trinity-devel] sip4-tqt FTBFS (debian/testing). Quit patch.
>In general there are two ways to tosubmit patches:
>1.) Submit a patch to the mailing list for ACK/NAK
before committing to GIT
>....
>encountered and the subsequent reasoning behind the patch.
Thanks Tim, very useful as usual.
I guess I need to be "enabled (i.e. registered)" before being able to commit to
the GIT repo, isn't it?
Michele
6:40 a.m.
New subject: [trinity-devel] sip4-tqt FTBFS (debian/testing). Quit patch.
>In general
there are two ways to tosubmit patches:
>1.) Submit a patch to the mailing list for
ACK/NAK before committing to
> GIT
>....
>encountered and the subsequent reasoning behind the patch.
Thanks Tim, very useful as usual.
I guess I need to be "enabled (i.e. registered)" before being able to
commit to the GIT repo, isn't it?
Michele
17 Dec
17 Dec
3:35 a.m.
New subject: [trinity-devel] sip4-tqt FTBFS (debian/testing). Quit patch.
HI there,
following further investigation I came to find the problem I had with both sip4-tqt and
python-tqt.
Though I had managed to fix sip4-tqt with a small patch, this patch is actually NOT
needed.
I have created a few scripts to help me in building the different packages of TDE,
create/update
the local repository, etc...
In one of these scripts, I setup the directories before launching the building process and
to keep
my GIT folder clean I always copy the GIT source to a new folder.
It turns out that using "-p" to preserve file attributes when "cp"-ing
folders caused the building
failure in sip4-tqt, even though it hadn't caused any problem in all previous
packages.
Removing "-p" allowed to:
1) build sip4-tqt without requiring any patch
2) compiling python-tqt without any problem at all, while instead using the sip4-tqt built
with the
"-p" and the patch was failing.
So in summary: the patch for sip4-tqt is NOT needed. Darrell, you don't need to merge
it.
Sorry for the confusion created.
Cheers
Michele
14 Dec
14 Dec
9:05 a.m.
New subject: [trinity-devel] sip4-tqt FTBFS (debian/testing). Quit patch.
Hi there,
sip4-tqt FTBFS on my computer (debian/testing). I used the most recent GIT
sources for both TDE and
TDE-packaging (2012/12/14).
The problem is in compiling the sipgen module, when the sip.h file is not
found.
<snip>
If no one else sees a problem with this patch, I'm going to give it an ACK.
Darrell, can you commit it to GIT under Michele's name if no one objects
by tomorrow?
Thanks!
Tim
> gcc -c -O2 -g -I/usr/include/tqt
-I/usr/include/tqt3 -I/usr/include/qt3
> -w -DNDEBUG -I. -o parser.o parser.c
> /home/tde_src/2_build/build/dependencies/sip4-tqt/sipgen/parser.y:24:17:
> fatal error: sip.h: No such file or directory
The patch adds the module source folder to the include path when
generating the makefiles.
4358
days inactive
4361
days old
6 comments
2 participants
participants (2)
-
Michele Calgaro -
Timothy Pearson