TDE devs,
I passed this along to Yasuhiko for openSUSE kde3, it may also be something that TDE wants to patch as well:
========== original message ============
The current rust.xml katepart syntax file does not highlight alerts like TODO, FIXME, etc. in the comments. The katepart/syntax file needs to be updated to include the katepart/syntax/alerts.xml file.
A patch to do so is:
diff -ruNb a/syntax/rust.xml b/syntax/rust.xml --- a/syntax/rust.xml 2015-10-28 15:38:53.000000000 -0500 +++ b/syntax/rust.xml 2024-09-10 08:53:59.108745900 -0500 @@ -323,10 +323,14 @@ <RegExpr String="U[0-9a-fA-F]{8}" attribute="CharEscape" context="#pop"/> <RegExpr String="." attribute="Error" context="#pop"/> </context> - <context attribute="Comment" lineEndContext="#pop" name="Commentar 1"/> + <context attribute="Comment" lineEndContext="#pop" name="Commentar 1"> + <LineContinue attribute="Comment" context="#stay"/> + <IncludeRules context="##Alerts" /> + </context> <context attribute="Comment" lineEndContext="#stay" name="Commentar 2"> <DetectSpaces/> <Detect2Chars char="*" char1="/" attribute="Comment" context="#pop" endRegion="Comment"/> + <IncludeRules context="##Alerts" /> </context> </contexts> <itemDatas> @@ -348,6 +352,7 @@ <itemData name="Macro" defStyleNum="dsOthers"/> <itemData name="Attribute" defStyleNum="dsOthers"/> <itemData name="Lifetime" defStyleNum="dsOthers" bold="1"/> + <itemData name="Alert" defStyleNum="dsAlert" spellChecking="false"/> <itemData name="Error" defStyleNum="dsError"/> </itemDatas> </highlighting>
On 2024/09/11 03:31 PM, David C. Rankin via tde-devels wrote:
TDE devs,
I passed this along to Yasuhiko for openSUSE kde3, it may also be something that TDE wants to patch as well:
Hi David, thanks for the info. Would you mind posting a link to the patch, so we can reference that in our commit message? Cheers Michele
On 9/11/24 4:08 AM, Michele Calgaro via tde-devels wrote:
Hi David, thanks for the info. Would you mind posting a link to the patch, so we can reference that in our commit message? Cheers Michele
The patch is from my laptop :)
When Yasuhiko adds it I'll give you the link from openSUSE. So far I've just provided the patch to TDE and openSUSE.
On 2024/09/11 03:31 PM, David C. Rankin via tde-devels wrote:
TDE devs,
I passed this along to Yasuhiko for openSUSE kde3, it may also be something that TDE wants to patch as well:
========== original message ============
The current rust.xml katepart syntax file does not highlight alerts like TODO, FIXME, etc. in the comments. The katepart/syntax file needs to be updated to include the katepart/syntax/alerts.xml file.
Thanks David, I create a PR out of your patch and credited you as author, since you mentioned the patch was from your computer :-) Cheers Michele
On 9/24/24 3:16 AM, Michele Calgaro via tde-devels wrote:
On 2024/09/11 03:31 PM, David C. Rankin via tde-devels wrote:
TDE devs,
I passed this along to Yasuhiko for openSUSE kde3, it may also be something that TDE wants to patch as well:
========== original message ============
The current rust.xml katepart syntax file does not highlight alerts like TODO, FIXME, etc. in the comments. The katepart/syntax file needs to be updated to include the katepart/syntax/alerts.xml file.
Thanks David, I create a PR out of your patch and credited you as author, since you mentioned the patch was from your computer :-) Cheers Michele
Thank you Michele,
Indeed it is accurate:
14:04 wizard:~/tmp/diff> tree --charset=ASCII . |-- a | `-- syntax | `-- rust.xml |-- b | `-- syntax | `-- rust.xml `-- kde3-syntax-rust-alert.patch