Calvin Morrison via tde-devels wrote:
I 'created' the repo in gitea as well
https://mirror.git.trinitydesktop.org/gitea/ceux/tmix
thanks!
Very good congrats!
Here some remarks:
1. generally we split the CMakeLists.txt in project specific and code specific part. Just open one project and have a look. It is more convenient, nothing against putting everything in one. 2. do not use hardcoded paths for example
include_directories( - ${CMAKE_CURRENT_BINARY_DIR} - ${TQT_INCLUDE_DIRS} - /usr/include/tqt3 - /usr/include/tqt - ${TDE_INCLUDE_DIR} - /opt/trinity/include - ${PULSE_INCLUDE_DIRS} + ${CMAKE_BINARY_DIR} + ${CMAKE_CURRENT_BINARY_DIR} + ${CMAKE_CURRENT_SOURCE_DIR} + ${TDE_INCLUDE_DIR} + ${TQT_INCLUDE_DIRS} + ${PULSE_INCLUDE_DIRS} )
3. At some point of time kuniqueapplication did change into tdeuniqueapplication
-#include <kuniqueapplication.h> +#include <tdeuniqueapplication.h>
So even changing 2, then 3, then 1, I couldn't build
$ make all [ 3%] Generating src/tmixtray.moc [ 7%] Generating src/audiodevice.moc [ 11%] Generating src/balanceknob.moc [ 14%] Generating src/devicespage.moc [ 18%] Generating src/devicewidget.moc [ 22%] Generating src/kledbutton.moc [ 25%] Generating src/mixerwindow.moc [ 29%] Generating src/preferencesdlg.moc [ 33%] Generating src/pulsedevice.moc [ 37%] Generating src/pulsemodel.moc [ 40%] Generating src/tmixapp.moc [ 44%] Generating src/tmixpopup.moc [ 48%] Building CXX object src/CMakeFiles/tmix.dir/main.cpp.o /mnt/DEVELOPMENT/Projects/TDE/tmix/src/main.cpp:1:10: fatal error: tdeuniqueapplication.h: No such file or directory 1 | #include <tdeuniqueapplication.h> | ^~~~~~~~~~~~~~~~~~~~~~~~ compilation terminated.