11 Mar
2020
11 Mar
'20
4:50 p.m.
Hi all,
as you probably know, if tdelibs are compiled with elf editor support
(WITH_ELFICON), the application icon, TDE information and git repository
information are embedded into libraries and binaries during CMake build.
This data, on the one hand, provides user convenience - better to see the
application icon than the general binaries icon. On the other hand, they
provide information to developers - for example, when reporting creashes.
It is possible that you have also heard about the activity Reproducible
builds, which seems to us as a very good idea. See:
https://reproducible-builds.org/
https://wiki.debian.org/ReproducibleBuilds
Currently, the metadata that are embedded has a Compilation Date/Time
entry. This is set to the current date and time at the time of building
the binary package. And this is a problem because it makes it impossible
to achieve reproducible builds.
My suggestion is that next to the ".tdescmmodule" and
".tdescmrevision"
files we could have a ".tdescmdatetime" file containing the git commit
date and/or a ".tdepackagedatetime" file containing the date the source
package was created for distribution. For embedded metadata, this fixed
time would be used instead of variable time.
What is your opinion?
Cheers
--
Slávek
12 Mar
12 Mar
2:22 a.m.
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
On 2020/03/12 01:50 AM, Slávek Banko wrote:
Hi all,
as you probably know, if tdelibs are compiled with elf editor support (WITH_ELFICON), the
application icon, TDE
information and git repository information are embedded into libraries and binaries
during CMake build.
This data, on the one hand, provides user convenience - better to see the application
icon than the general
binaries icon. On the other hand, they provide information to developers - for example,
when reporting creashes.
It is possible that you have also heard about the activity Reproducible builds, which
seems to us as a very good
idea. See:
https://reproducible-builds.org/ https://wiki.debian.org/ReproducibleBuilds
Currently, the metadata that are embedded has a Compilation Date/Time entry. This is set
to the current date and
time at the time of building the binary package. And this is a problem because it makes
it impossible to achieve
reproducible builds.
My suggestion is that next to the ".tdescmmodule" and
".tdescmrevision" files we could have a ".tdescmdatetime"
file containing the git commit date and/or a ".tdepackagedatetime" file
containing the date the source package was
created for distribution. For embedded metadata, this fixed time would be used instead of
variable time.
What is your opinion?
Cheers
Hi Slavek,
glad that you have brought up this issue, since it is something I have experienced several
times when checking the
"drop automake" PR in the last few months.
I also feel it is good to have reproducible builds. We already have the
".tdescmmodule" and ".tdescmrevision" which
contains the git commit hash the package was build from. Nevertheless we are missing the
tde-packaging hash in those
files.
Rather than having too many .tdescmXXXXX files, I propose we use a single .tdegitinfo file
which includes module name,
repo git hash and packaging repo hash.
I don't see any need for any date in the package once we have the git hash info.
Cheers
Michele
-----BEGIN PGP SIGNATURE-----
iQIzBAEBCgAdFiEEjhl1z5vbYB3YbFTiKnW3yore1c8FAl5pnMIACgkQKnW3yore
1c+jkA/9HAN5LtZ50xaaG6jGeNn2gXG0ot7hgTu3CCxlzasRxyhzsbDsMGu38QCv
ObM7kbvWMEPQHnQxk8HG8n2HIqcVLcdK8NPy5sXA4MQLwbIbb5uRP7JFOvac+ad9
IB8jfLCtrfwvbG1ChuUmVmiwYqEliz4KXrLYxEG5DgCjKH1/hcqa824gYLUDG10l
YP1G72yfaJWXZEuq7uSs07owNPfhbDxWv5Y+v74HjhwAdqEnYu1XFr6r3HRd1LA6
NIXTChxYWwCWCc72DrE9G4j2CG6e4HuUgIKvzSMQKvHGovswxKBg4Guzetez/gWb
mIZKSU+F2id1BrnEiO+T9FQzyDU2WmwAsaF+RHZiwrSdQNsj42JPELcYQsP/hhxP
l9GxTHMy1V32lA+p5HwOap2Fhz/VLEh4ikYgnsHqofPhRSeC3uuMZwkG3ed+mRwO
gexwAjh9A7AqWMbWXJB/N0d1C//l/Z7BvbWIIiFnaDogkGZCpx5tQ7XOcU+vFLuS
7gID0E0wU8Ysr10sVp0sIq6kEVgXD3t88V/rSh3qMnV9KP3cNV+eUFWRIyPCplMM
5I0FUqIeJuUPrvuDm74WGbb6SxJ+XgRhZXd+rkxUJABozrBrvQd4gj+qM7CQKKr7
E04GuedV4L/9xZJImMI7z8k0oLtjZte9ZhhHrqle8hs5/PmYQlE=
=Bdww
-----END PGP SIGNATURE-----
---------------------------------------------------------------------
To unsubscribe, e-mail: trinity-devel-unsubscribe(a)lists.pearsoncomputing.net
For additional commands, e-mail: trinity-devel-help(a)lists.pearsoncomputing.net
Read list messages on the web archive: http://trinity-devel.pearsoncomputing.net/
Please remember not to top-post:
http://trinity.pearsoncomputing.net/mailing_lists/#top-posting
1:25 p.m.
On Thursday 12 of March 2020 03:22:10 Michele Calgaro via trinity-devel
wrote:
On 2020/03/12 01:50 AM, Slávek Banko wrote:
Thank Michele, it is a good idea that instead of many files we can
consolidate git repository information into one file. I will prepare
patches / pull-requests in this sense.
Since the tde-packaging repository information and package information for
each distribution are independent, a separate package information file
will be required.
At the same time, git hash for tde-packaging is not enough for us, because
there is also interesting information about the distribution. In addition,
here can be forced rebuild without any changes in the git repositories -
as an example here is the 'libr' with dependency on binutils. Therefore,
it is still useful for us information about date+time and/or the version
of the package for a specific distribution.
Cheers
--
Slávek
Hi all,
as you probably know, if tdelibs are compiled with elf editor support
(WITH_ELFICON), the application icon, TDE information and git
repository information are embedded into libraries and binaries during
CMake build.
This data, on the one hand, provides user convenience - better to see
the application icon than the general binaries icon. On the other
hand, they provide information to developers - for example, when
reporting creashes.
It is possible that you have also heard about the activity
Reproducible builds, which seems to us as a very good idea. See:
https://reproducible-builds.org/
https://wiki.debian.org/ReproducibleBuilds
Currently, the metadata that are embedded has a Compilation Date/Time
entry. This is set to the current date and time at the time of
building the binary package. And this is a problem because it makes it
impossible to achieve reproducible builds.
My suggestion is that next to the ".tdescmmodule" and
".tdescmrevision" files we could have a ".tdescmdatetime" file
containing the git commit date and/or a ".tdepackagedatetime" file
containing the date the source package was created for distribution.
For embedded metadata, this fixed time would be used instead of
variable time.
What is your opinion?
Cheers
Hi Slavek,
glad that you have brought up this issue, since it is something I have
experienced several times when checking the "drop automake" PR in the
last few months.
I also feel it is good to have reproducible builds. We already have the
".tdescmmodule" and ".tdescmrevision" which contains the git commit
hash
the package was build from. Nevertheless we are missing the
tde-packaging hash in those files.
Rather than having too many .tdescmXXXXX files, I propose we use a
single .tdegitinfo file which includes module name, repo git hash and
packaging repo hash.
I don't see any need for any date in the package once we have the git
hash info.
Cheers
Michele
13 Mar
13 Mar
1:17 a.m.
On Thursday 12 of March 2020 14:25:32 Slávek Banko wrote:
On Thursday 12 of March 2020 03:22:10 Michele Calgaro
via trinity-devel
wrote:
The puzzle pieces are as follows:
1. The create_tarball script instead of individual .tdescmmodule
and .tdescmrevision files creates a single .tdescminfo file that contains
the SCM module name, revision, and date of the last commit:
https://mirror.git.trinitydesktop.org/gitea/TDE/scripts/pulls/2
2. DEB packaging ensure that a .tdepkginfo file with package metadata is
generated during build:
https://mirror.git.trinitydesktop.org/gitea/TDE/tde-packaging/pulls/63
3. The CMake macro retrieves information from .tdescminfo as well as
information from .tdepkginfo in source or binary directory. And then use
TDE_PKG_DATETIME, or TDE_SCM_MODULE_DATETIME, or the current date:
https://mirror.git.trinitydesktop.org/gitea/TDE/tde-common-cmake/pulls/32
As a result of these pull requests, for deb packages, the date for embedded
metadata will consistently contain information about the time the source
package was created. So it looks like a good starting point.
So far my initial tests are giving strange results. When I made two
independent chroots on the builder (both bullseye@amd64) and trying to
build abakus package manually using dpkg-buildpackage, I repeatedly get
identical binary packages - the only difference is the "buildinfo" file
that contains the build date. When I use automated building with sbuild, I
get different binary packages. For now I don't know the cause.
Cheers
--
Slávek
On 2020/03/12 01:50 AM, Slávek Banko wrote:
Thank Michele, it is a good idea that instead of many files we can
consolidate git repository information into one file. I will prepare
patches / pull-requests in this sense.
Since the tde-packaging repository information and package information
for each distribution are independent, a separate package information
file will be required.
At the same time, git hash for tde-packaging is not enough for us,
because there is also interesting information about the distribution. In
addition, here can be forced rebuild without any changes in the git
repositories - as an example here is the 'libr' with dependency on
binutils. Therefore, it is still useful for us information about
date+time and/or the version of the package for a specific distribution.
Cheers Hi all,
as you probably know, if tdelibs are compiled with elf editor
support (WITH_ELFICON), the application icon, TDE information and
git repository information are embedded into libraries and binaries
during CMake build.
This data, on the one hand, provides user convenience - better to
see the application icon than the general binaries icon. On the
other hand, they provide information to developers - for example,
when reporting creashes.
It is possible that you have also heard about the activity
Reproducible builds, which seems to us as a very good idea. See:
https://reproducible-builds.org/
https://wiki.debian.org/ReproducibleBuilds
Currently, the metadata that are embedded has a Compilation
Date/Time entry. This is set to the current date and time at the
time of building the binary package. And this is a problem because
it makes it impossible to achieve reproducible builds.
My suggestion is that next to the ".tdescmmodule" and
".tdescmrevision" files we could have a ".tdescmdatetime" file
containing the git commit date and/or a ".tdepackagedatetime" file
containing the date the source package was created for distribution.
For embedded metadata, this fixed time would be used instead of
variable time.
What is your opinion?
Cheers
Hi Slavek,
glad that you have brought up this issue, since it is something I have
experienced several times when checking the "drop automake" PR in the
last few months.
I also feel it is good to have reproducible builds. We already have
the ".tdescmmodule" and ".tdescmrevision" which contains the git
commit hash the package was build from. Nevertheless we are missing
the
tde-packaging hash in those files.
Rather than having too many .tdescmXXXXX files, I propose we use a
single .tdegitinfo file which includes module name, repo git hash and
packaging repo hash.
I don't see any need for any date in the package once we have the git
hash info.
Cheers
Michele
1512
days inactive
1514
days old
3 comments
2 participants
participants (2)
-
Michele Calgaro via trinity-devel -
Slávek Banko