Patch to remove non-existing icon positions in ~/.trinity/share/apps/kdesktop/IconPositions
Hi all,
This is a simple patch against .trinity/share/apps/kdesktop/IconPositions growing indefinitly. Mine was almost 500MB and contained stuff from the last decades - so not very useful, but TDE has no way to clean this file.
The patch goes against kdesktop/kdiconview.cpp. It changes the baviour to only save icon positions when the file/directory acually exists on the desktop.
Nik
Anno domini 2026 Sat, 13 Jun 17:45:44 +0200 Dr. Nikolaus Klepp via tde-devels scripsit:
Hi all,
This is a simple patch against .trinity/share/apps/kdesktop/IconPositions growing indefinitly. Mine was almost 500MB and contained stuff from the last decades - so not very useful, but TDE has no way to clean this file.
The patch goes against kdesktop/kdiconview.cpp. It changes the baviour to only save icon positions when the file/directory acually exists on the desktop.
oops ... patch is reverse, this is the correct one
Nik
On 2026/06/14 12:47 AM, Dr. Nikolaus Klepp via tde-devels wrote:
Anno domini 2026 Sat, 13 Jun 17:45:44 +0200 Dr. Nikolaus Klepp via tde-devels scripsit:
Hi all,
This is a simple patch against .trinity/share/apps/kdesktop/IconPositions growing indefinitly. Mine was almost 500MB and contained stuff from the last decades - so not very useful, but TDE has no way to clean this file.
The patch goes against kdesktop/kdiconview.cpp. It changes the baviour to only save icon positions when the file/directory acually exists on the desktop.
oops ... patch is reverse, this is the correct one
Hi Nik, can you create patch on our Gitea instance? That is preferred way to contribute. Cheers Michele
Hi Michele,
Anno domini 2026 Tue, 16 Jun 17:35:23 +0900 Michele Calgaro via tde-devels scripsit:
On 2026/06/14 12:47 AM, Dr. Nikolaus Klepp via tde-devels wrote:
Anno domini 2026 Sat, 13 Jun 17:45:44 +0200 Dr. Nikolaus Klepp via tde-devels scripsit:
Hi all,
This is a simple patch against .trinity/share/apps/kdesktop/IconPositions growing indefinitly. Mine was almost 500MB and contained stuff from the last decades - so not very useful, but TDE has no way to clean this file.
The patch goes against kdesktop/kdiconview.cpp. It changes the baviour to only save icon positions when the file/directory acually exists on the desktop.
oops ... patch is reverse, this is the correct one
Hi Nik, can you create patch on our Gitea instance? That is preferred way to contribute.
I tried but I'm stuck somehow. I can log into gitea e.g. https://mirror.git.trinitydesktop.org/gitea/explore/repos
Following the steps on https://wiki.trinitydesktop.org/TDE_Gitea_Workspace I did:
$ git checkout -b feat/kdesktop_clenup_iconpositions
Then appy my changes and try to upload:
$ git push -u origin feat/kdesktop_clenup_iconpositions Password for 'https://Dr_Nikolaus_Klepp@mirror.git.trinitydesktop.org': Gesamt 0 (Delta 0), Wiederverwendet 0 (Delta 0), Paket wiederverwendet 0 (von 0) remote: remote: Gitea: User permission denied for writing. To https://mirror.git.trinitydesktop.org/gitea/TDE/tde ! [remote rejected] feat/kdesktop_clenup_iconpositions -> feat/kdesktop_clenup_iconpositions (pre-receive hook declined) Fehler: Fehler beim Versenden einiger Referenzen nach 'https://mirror.git.trinitydesktop.org/gitea/TDE/tde'
So is the password from the webinterface doesnot work here? Do I miss something?
Nik
Cheers Michele
I tried but I'm stuck somehow. I can log into gitea e.g. https://mirror.git.trinitydesktop.org/gitea/explore/repos
Following the steps on https://wiki.trinitydesktop.org/TDE_Gitea_Workspace I did:
$ git checkout -b feat/kdesktop_clenup_iconpositions
Then appy my changes and try to upload:
$ git push -u origin feat/kdesktop_clenup_iconpositions Password for 'https://Dr_Nikolaus_Klepp@mirror.git.trinitydesktop.org': Gesamt 0 (Delta 0), Wiederverwendet 0 (Delta 0), Paket wiederverwendet 0 (von 0) remote: remote: Gitea: User permission denied for writing. To https://mirror.git.trinitydesktop.org/gitea/TDE/tde ! [remote rejected] feat/kdesktop_clenup_iconpositions -> feat/kdesktop_clenup_iconpositions (pre-receive hook declined) Fehler: Fehler beim Versenden einiger Referenzen nach 'https://mirror.git.trinitydesktop.org/gitea/TDE/tde'
So is the password from the webinterface doesnot work here? Do I miss something?
Can you check to make sure you cloned the repository from TGW and not from the main TDE box? Run "git remote -vv" and see where it points. For example for tdebase you should get something like this:
origin gitea@mirror.git.trinitydesktop.org:TDE/tdebase.git (fetch) origin gitea@mirror.git.trinitydesktop.org:TDE/tdebase.git (push)
Let me know. Cheers Michele
Anno domini 2026 Wed, 17 Jun 11:38:42 +0900 Michele Calgaro via tde-devels scripsit:
I tried but I'm stuck somehow. I can log into gitea e.g. https://mirror.git.trinitydesktop.org/gitea/explore/repos
Following the steps on https://wiki.trinitydesktop.org/TDE_Gitea_Workspace I did:
$ git checkout -b feat/kdesktop_clenup_iconpositions
Then appy my changes and try to upload:
$ git push -u origin feat/kdesktop_clenup_iconpositions Password for 'https://Dr_Nikolaus_Klepp@mirror.git.trinitydesktop.org': Gesamt 0 (Delta 0), Wiederverwendet 0 (Delta 0), Paket wiederverwendet 0 (von 0) remote: remote: Gitea: User permission denied for writing. To https://mirror.git.trinitydesktop.org/gitea/TDE/tde ! [remote rejected] feat/kdesktop_clenup_iconpositions -> feat/kdesktop_clenup_iconpositions (pre-receive hook declined) Fehler: Fehler beim Versenden einiger Referenzen nach 'https://mirror.git.trinitydesktop.org/gitea/TDE/tde'
So is the password from the webinterface doesnot work here? Do I miss something?
Can you check to make sure you cloned the repository from TGW and not from the main TDE box? Run "git remote -vv" and see where it points. For example for tdebase you should get something like this:
origin gitea@mirror.git.trinitydesktop.org:TDE/tdebase.git (fetch) origin gitea@mirror.git.trinitydesktop.org:TDE/tdebase.git (push)
Hm, mine looks a bit different:
$ git remote -vv origin https://Dr_Nikolaus_Klepp@mirror.git.trinitydesktop.org/gitea/TDE/tde (fetch) origin https://Dr_Nikolaus_Klepp@mirror.git.trinitydesktop.org/gitea/TDE/tde (push)
Nik
Let me know. Cheers Michele
Can you check to make sure you cloned the repository from TGW and not from the main TDE box? Run "git remote -vv" and see where it points. For example for tdebase you should get something like this:
origin gitea@mirror.git.trinitydesktop.org:TDE/tdebase.git (fetch) origin gitea@mirror.git.trinitydesktop.org:TDE/tdebase.git (push)
Hm, mine looks a bit different:
$ git remote -vv origin https://Dr_Nikolaus_Klepp@mirror.git.trinitydesktop.org/gitea/TDE/tde (fetch) origin https://Dr_Nikolaus_Klepp@mirror.git.trinitydesktop.org/gitea/TDE/tde (push)
You can use `git remote rm origin` to remove the existing one, then `git remote add origin gitea@mirror.git.trinitydesktop.org:TDE/tdebase.git` to add the correct one. Then `git fetch --all` and `git pull --rebase` to make sure everything is up to date. Cheers Michele
Hi Michele,
Anno domini 2026 Wed, 17 Jun 19:35:54 +0900 Michele Calgaro via tde-devels scripsit:
Can you check to make sure you cloned the repository from TGW and not from the main TDE box? Run "git remote -vv" and see where it points. For example for tdebase you should get something like this:
origin gitea@mirror.git.trinitydesktop.org:TDE/tdebase.git (fetch) origin gitea@mirror.git.trinitydesktop.org:TDE/tdebase.git (push)
Hm, mine looks a bit different:
$ git remote -vv origin https://Dr_Nikolaus_Klepp@mirror.git.trinitydesktop.org/gitea/TDE/tde (fetch) origin https://Dr_Nikolaus_Klepp@mirror.git.trinitydesktop.org/gitea/TDE/tde (push)
You can use `git remote rm origin` to remove the existing one, then `git remote add origin gitea@mirror.git.trinitydesktop.org:TDE/tdebase.git` to add the correct one. Then `git fetch --all` and `git pull --rebase` to make sure everything is up to date. Cheers Michele
Wow, I did it! Thank you so much :) https://mirror.git.trinitydesktop.org/gitea/TDE/tdebase/pulls/755
Nik
Wow, I did it! Thank you so much :) https://mirror.git.trinitydesktop.org/gitea/TDE/tdebase/pulls/755
Nik
Thanks, will look at it this weekend, or earlier if I manage. Cheers Michele
-
Dr. Nikolaus Klepp -
Michele Calgaro